herblore Herblore Cleaner - Clean Herbs extremely fast with multiple locations

[BryceTheCoder]

100% Working Bot from EpiXBots!

 

 

 

Direct Download Link: http://dl.dropbox.com/u/59782961/HerbCleaner.zip

 

Other 100% Working Bots: http://www.EpiXBots.webs.com

[Wanted]

Interesting, you have a bunch of stuff included, yet you don't seem to use any of those extra files in your script so you can really delete everything all you need is {$I OSI\OSI.scar}

 

[sCAR]case ComboBox1.ItemIndex of

0: WhichBank:= 1;

1: WhichBank:= 2;

2: WhichBank:= 3;

else Logout;[/sCAR]

 

You could just do

 

[sCAR]WhichBank := ComboBox1.ItemIndex + 1;

if (not (InRange(WhichBank, 1, 3))) then

Logout;[/sCAR]

 

if you store the players BankPin in Players[CurrentPlayer].Pin := '0000'; OpenBank will do it automatically for you

 

[sCAR] Slot := GetItemBounds(i);

MouseBox(Slot.X1, Slot.Y1, Slot.X2, Slot.Y2, ClickLeft);[/sCAR]

 

You could just use MouseItem(I, ClickLeft);

 

[sCAR] if WhichBank = 1 then

begin

OpenBankEx(Loc_VWB, True, True, True);

end;

if WhichBank = 2 then

begin

OpenBankEx(Loc_VEB, True, True, True);

end;

if WhichBank = 3 then

begin

OpenBankEx(Loc_AKB, True, True, True);

end;[/sCAR]

 

Uses cases or something.. match up WhichBank with the real Indexes in Global.scar so you can just do OpenBankEx(WhichBank

 

[sCAR] if RadioButton1.Checked then

begin

CleanEm;

end;[/sCAR]

 

You don't need begin end for single lines

 

[sCAR]if RadioButton1.Checked then

CleanEm;[/sCAR]

 

I haven't tested the script yet but I'm sure it probably works alright, just work on the fundamentals and learn the tricks and you'll find coding scripts with OSI is even easier than you imagined

Edited February 26, 2012 by Wanted

[BryceTheCoder]

Thnx 4 saying some improvements wanted:) And i always do the "begin and end" even if its only one line becuase im used to coding javascript and begin and end is like the brackets { and } sooo im used to it buut yaa i could remember to just have then and it works fine:)

[Bixby Sayz]

Links are broken/dead. Is this script dead, or is this the same script listed on the UB website?

[shadowrecon]

Links are broken/dead. Is this script dead, or is this the same script listed on the UB website?

Its not the same one, but i think he just removed it? Have you happen to try the one i have posted? Its works pretty good, just do not use the darn GE! lol. The ge banking method has killed me i dunno what it is but it takes ages to find bank ect... In the new update ive removed the Ge =p lol

[Bixby Sayz]

I seemed to have messed up on the checkout process somewhere/somehow (God I get I stupified when I'm tired). I'll give it another go later.