LordJashin Posted September 17, 2012 Share Posted September 17, 2012 The login procedure is messing up because of the toolbar. It shows up after login for some reason. So i guess we can change the constants to + 50 px. What needs to be done, just that right? Or anything else to fix the toolbar issue? Quote Link to comment Share on other sites More sharing options...
Bixby Sayz Posted September 17, 2012 Share Posted September 17, 2012 Backwards port the change from the 3.35 version? During SetUpOSI Freddy has put a call to UpdateRSClient which basically shifts the client "down" 50 pixels. Quote Link to comment Share on other sites More sharing options...
LordJashin Posted September 17, 2012 Author Share Posted September 17, 2012 Its like SCAR 3.35 was made just in time to fix the toolbar issue lols. There is no way to backport this is there? [sCAR] {=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= procedure UpdateRSClient; Contributors: Freddy Description: Updates the client and excludes the toolbar from the client area. Date Created: July 21th 2012. By Freddy. RS2 Build 725. Last Modified: July 21th 2012. By Freddy. RS2 Build 725. =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=} procedure UpdateRSClient; var Client: TSCARClient; begin Client := GetClient; if Client.Update then begin with Client.ImageArea do Client.ImageArea := Box(X1, Y1 + 50, X2, Y2); with Client.InputArea do Client.InputArea := Box(X1, Y1 + 50, X2, Y2); end; end; [/sCAR] Just want meh SPS, working Quote Link to comment Share on other sites More sharing options...
Bixby Sayz Posted September 17, 2012 Share Posted September 17, 2012 Its like SCAR 3.35 was made just in time to fix the toolbar issue lols. There is no way to backport this is there?Crap. You're right. Wasn't thinking on that one. Quote Link to comment Share on other sites More sharing options...
LordJashin Posted September 17, 2012 Author Share Posted September 17, 2012 Crap. You're right. Wasn't thinking on that one. Just goes to show. Having half or more of OSI functions based on absolute coordinates, and not much constant usage. Can really mess up everything. It should all be relative. If i move RSY1 to 50. EVERYTHING should still work, but that's not how it goes. I will be making a gigantic pull request soon for the constants and dependence. If anyone uses the inventory functions, they are awesome because of the relative coordinates stuff! Quote Link to comment Share on other sites More sharing options...
Bixby Sayz Posted September 17, 2012 Share Posted September 17, 2012 Lol. As much as I feel for you I have to chuckle at bit at the pain of adapting the includes for the toolbar. I once suggested moving to more relative coords way back when but there wasn't much appetite for it at the time. Nobody could see how all that extra upfront work would ever pay off. Guess ya never know. Quote Link to comment Share on other sites More sharing options...
LordJashin Posted September 17, 2012 Author Share Posted September 17, 2012 Lol. As much as I feel for you I have to chuckle at bit at the pain of adapting the includes for the toolbar. I once suggested moving to more relative coords way back when but there wasn't much appetite for it at the time. Nobody could see how all that extra upfront work would ever pay off. Guess ya never know. And in the end. I will be the last one laughing when they come back to see the include using relative. And they'll have a dull moment of obstinacy. But right now, this just shows how relative would've been smarter, so that rs2'z toolbarz wouldn't fire itz lazerz at OSI'z coordz. Quote Link to comment Share on other sites More sharing options...